-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preDeployedContract hardfork #5
Merged
owen-reorg
merged 2 commits into
bnb-chain:develop
from
redhdx:feature/modify_predeploy_contracts
Aug 8, 2023
Merged
feat: add preDeployedContract hardfork #5
owen-reorg
merged 2 commits into
bnb-chain:develop
from
redhdx:feature/modify_predeploy_contracts
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymbol and remove GovernanceToken
owen-reorg
approved these changes
Aug 7, 2023
brilliant-lx
approved these changes
Aug 8, 2023
MrCrazid
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What now how does this affect me
owen-reorg
pushed a commit
that referenced
this pull request
Oct 18, 2023
* feat: add precompiled contracts for Greenfield link * fix bug in lightclient * fix the comments * feature: add hardfork logic (#1) * feature: update hard fork info (#3) * Fix/fix dockerfile (#4) * fix: add libc-dev to support greenfield * feature: update devnet fork block number * feature: update chain config info (#5) --------- Co-authored-by: redhdx <[email protected]>
redhdx
pushed a commit
to redhdx/op-geth
that referenced
this pull request
Mar 20, 2024
feature(op-geth): code refine
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Jul 26, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Jul 31, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Aug 12, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
that referenced
this pull request
Aug 14, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
that referenced
this pull request
Sep 26, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Oct 15, 2024
* make the number of p2p parallel enqueue routines fixable * make the number of p2p parallel enqueue routines fixable * fix issue of 'logging in init() function is not working' * add detailed metrics for txpool.Add() function --------- Co-authored-by: andyzhang2023 <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
andyzhang2023
referenced
this pull request
in andyzhang2023/op-geth
Oct 29, 2024
* make the number of p2p parallel enqueue routines fixable * make the number of p2p parallel enqueue routines fixable * fix issue of 'logging in init() function is not working' * add detailed metrics for txpool.Add() function --------- Co-authored-by: andyzhang2023 <[email protected]>
sunny2022da
added a commit
that referenced
this pull request
Dec 11, 2024
* fix several UT with racing issues * fix incorrect nonce balance codehash issue case: TestEIP1559 / TestDeleteThenCreate * Fix ExecutionSpec tests mainly root caused by balance not updated to dirty correctly. also fix similar issue with nonce and codehash. * fix TestBlockChain testcase issue TestBlockchain/ValidBlocks/bcStateTests/refundReset.json Co-authored-by: Sunny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature is add preDeployedContract hardfork to change preDeployed contract
WBNB
name
andsymbol
, and remove preDeployed contract GovernanceToken.Rationale
The preDeployed contract
WBNB
address is0x4200000000000000000000000000000000000006
,name
andsymbol
is not correct, so it should be changed toWrapped BNB
andWBNB
. AndOP-BNB
doesn't need GovernanceToken,so the preDeployed contract
4200000000000000000000000000000000000042
should be removed.Changes
Set preDeployed contract
WBNB
name
toWrapped BNB
.Set preDeployed contract
WBNB
symbol
toWBNB
.Remove preDeployed contract
4200000000000000000000000000000000000042