Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preDeployedContract hardfork #5

Merged

Conversation

redhdx
Copy link
Contributor

@redhdx redhdx commented Aug 1, 2023

Description

This feature is add preDeployedContract hardfork to change preDeployed contract WBNB name and symbol, and remove preDeployed contract GovernanceToken.

Rationale

The preDeployed contract WBNB address is 0x4200000000000000000000000000000000000006 , name and symbol is not correct, so it should be changed to Wrapped BNB and WBNB. And OP-BNB doesn't need GovernanceToken,
so the preDeployed contract 4200000000000000000000000000000000000042 should be removed.

Changes

Set preDeployed contract WBNB name to Wrapped BNB.
Set preDeployed contract WBNB symbol to WBNB.
Remove preDeployed contract 4200000000000000000000000000000000000042

@owen-reorg owen-reorg merged commit 0b3e557 into bnb-chain:develop Aug 8, 2023
Copy link

@MrCrazid MrCrazid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What now how does this affect me

owen-reorg pushed a commit that referenced this pull request Oct 18, 2023
* feat: add precompiled contracts for Greenfield link

* fix bug in lightclient

* fix the comments

* feature: add hardfork logic (#1)

* feature: update hard fork info (#3)

* Fix/fix dockerfile (#4)

* fix: add libc-dev to support greenfield

* feature: update devnet fork block number

* feature: update chain config info (#5)

---------

Co-authored-by: redhdx <[email protected]>
redhdx pushed a commit to redhdx/op-geth that referenced this pull request Mar 20, 2024
andyzhang2023 referenced this pull request in andyzhang2023/op-geth Jul 26, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
andyzhang2023 referenced this pull request in andyzhang2023/op-geth Jul 31, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
andyzhang2023 referenced this pull request in andyzhang2023/op-geth Aug 12, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
sunny2022da added a commit that referenced this pull request Aug 14, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
sunny2022da added a commit that referenced this pull request Sep 26, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
andyzhang2023 referenced this pull request in andyzhang2023/op-geth Oct 15, 2024
* make the number of p2p parallel enqueue routines fixable

* make the number of p2p parallel enqueue routines fixable

* fix issue of 'logging in init() function is not working'

* add detailed metrics for txpool.Add() function

---------

Co-authored-by: andyzhang2023 <[email protected]>
welkin22 pushed a commit that referenced this pull request Oct 22, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
andyzhang2023 referenced this pull request in andyzhang2023/op-geth Oct 29, 2024
* make the number of p2p parallel enqueue routines fixable

* make the number of p2p parallel enqueue routines fixable

* fix issue of 'logging in init() function is not working'

* add detailed metrics for txpool.Add() function

---------

Co-authored-by: andyzhang2023 <[email protected]>
sunny2022da added a commit that referenced this pull request Dec 11, 2024
* fix several UT with racing issues

* fix incorrect nonce balance codehash issue

case: TestEIP1559 / TestDeleteThenCreate

* Fix ExecutionSpec tests

mainly root caused by balance not updated to dirty correctly.
also fix similar issue with nonce and codehash.

* fix TestBlockChain testcase issue

    TestBlockchain/ValidBlocks/bcStateTests/refundReset.json

Co-authored-by: Sunny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants